ci: drop codecov upload step#114
Merged
Merged
Conversation
Matches modern-di, which removed codecov from its CI rather than bumping codecov-action. Coverage is still computed and enforced locally: pyproject.toml sets --cov-fail-under=100, so the floor is protected by the test run itself. Keeps the --cov-report xml flag for parity with modern-di (cheap, no consumer). Operator follow-up: the CODECOV_TOKEN repo secret is now unused and can be deleted from Settings -> Secrets and variables -> Actions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
codecov/codecov-actionupload step fromci.yml. Matches the siblingmodern-diproject's CI, which also has no codecov step. Closes the "bump vs. drop" question deferred in #113.Why drop instead of bump
modern-di/_checks.ymldoes not run codecov. Mirroring that pattern keeps both repos in the modern-python org aligned on one CI shape.pyproject.tomlsetsaddopts = "--cov=. --cov-report term-missing --cov-fail-under=100", so any drop below 100% fails CI immediately. No external service needed to protect the floor.--cov-report xmlflag onjust testis kept for parity with modern-di (cheap, no consumer).Diff
7 lines removed in
.github/workflows/ci.yml(the codecov-action step, itsenvblock, and itswithblock).Operator follow-up
CODECOV_TOKENrepo secret is now unused. Can be deleted from Settings → Secrets and variables → Actions whenever convenient.Test plan
--cov-fail-under=100.🤖 Generated with Claude Code